RFR: 8320649: C2: Optimize scoped values [v9]

[Emanuel Peter]

On Thu, 7 Mar 2024 08:12:46 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> @rwestrel nice! I'll run our testing again, now that it is merged.
>> 
>> FYI: you have some whitespace issues in:
>> `src/hotspot/share/opto/callGenerator.cpp`
>
>> FYI: you have some whitespace issues in: `src/hotspot/share/opto/callGenerator.cpp`
> 
> Thanks. I missed it. Fixed now.

@rwestrel sorry for the extremely slow reaction here. I ran testing for Commit 16, and got this failure.

It does not seem to depend on the platform, get failures with x84, aarch, linux, windows.

I see these two extra flag combinations lead to failures:

`-XX:+UnlockExperimentalVMOptions -XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0`

`-server -Xcomp`


Test Failures (1)
-----------------
Custom Run Test: @Run: testFastPath15Runner - @Test: testFastPath15:
compiler.lib.ir_framework.shared.TestRunException: There was an error while invoking @Run method private void compiler.c2.irTests.TestScopedValue.testFastPath15Runner() throws java.lang.Exception
	at compiler.lib.ir_framework.test.CustomRunTest.invokeTest(CustomRunTest.java:162)
	at compiler.lib.ir_framework.test.CustomRunTest.run(CustomRunTest.java:87)
	at compiler.lib.ir_framework.test.TestVM.runTests(TestVM.java:861)
	at compiler.lib.ir_framework.test.TestVM.start(TestVM.java:252)
	at compiler.lib.ir_framework.test.TestVM.main(TestVM.java:165)
Caused by: java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at compiler.lib.ir_framework.test.CustomRunTest.invokeTest(CustomRunTest.java:159)
	... 4 more
Caused by: java.lang.RuntimeException: should have deoptimized
	at compiler.c2.irTests.TestScopedValue.testFastPath15Runner(TestScopedValue.java:490)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	... 6 more



	at compiler.lib.ir_framework.test.TestVM.runTests(TestVM.java:896)
	at compiler.lib.ir_framework.test.TestVM.start(TestVM.java:252)
	at compiler.lib.ir_framework.test.TestVM.main(TestVM.java:165)


  #############################################################
   - To only run the failed tests use -DTest, -DExclude,
     and/or -DScenarios.
   - To also get the standard output of the test VM run with
     -DReportStdout=true or for even more fine-grained logging
     use -DVerbose=true.
  #############################################################

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16966#issuecomment-2012103186