RFR: 8326438: C2: assert(ld->in(1)->Opcode() == Op_LoadN) failed: Assumption invalid: input to DecodeN is not LoadN

[Vladimir Kozlov]

On Thu, 21 Mar 2024 15:31:58 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

> The [`assert`](https://github.com/openjdk/jdk/blob/6f2676dc5f09d350c359f906b07f6f6d0d17f030/src/hotspot/share/opto/graphKit.cpp#L1567) added in [JDK-8310524](https://bugs.openjdk.org/browse/JDK-8310524) is too strong and may sometimes not hold due to the [GVN transformation in `LoadNode::make`](https://github.com/openjdk/jdk/blob/8cb9b479c529c058aee50f83920db650b0c18045/src/hotspot/share/opto/memnode.cpp#L973).
> 
> ### Changeset
> Remove the `assert`.
> 
> ### Testing
> N/A

Good.

> Add label to JBS something `test*hard`. I don't remember its exact name.

Never mind I see you did it already.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18434#pullrequestreview-1952890909