RFR: 8320725: C2: Add "is_associative" flag for floating-point add-reduction [v3]

[Bhavana Kilambi]

On Mon, 18 Mar 2024 12:54:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Naming changes: replace strict/non-strict with more technical terms
>
> src/hotspot/share/opto/vectornode.hpp line 270:
> 
>> 268:   // when it is auto-vectorized as auto-vectorization mandates the operation to be
>> 269:   // non-associative (strictly ordered).
>> 270:   bool _is_associative;
> 
> Could this be a `const`?

Hi, what is the reason to declare it as a `const`? It is declared as a `private` member variable with no "setter" function either. It is not easy to modify this value from any other part of the code anyway.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18034#discussion_r1534645192