RFR: 8328614: hsdis: dlsym can't find decode symbol [v2]

Magnus Ihse Bursie ihse at openjdk.org
Fri Mar 22 14:13:22 UTC 2024


On Thu, 21 Mar 2024 06:58:43 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols.
>> Tested with gcc and clang, and llvm and binutils backend.
>> 
>> I didn't find any use of the "DLL_ENTRY", so I removed it.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove swap file

Unless you start calling JDK functions, you will not make a program less stand-alone by including jni.h. In this case, you will only use a compile-time definition.

Ideally, we should have had more general EXPORT definitions separate from the rest of the JNI code, but someone started doing things that way, and well, here we are, 25 years later and now JNIEXPORT is everywhere in the JDK source base. :( I'd say that access to JNIEXPORT is about 50% of the reason jni.h is included...

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2015191729


More information about the hotspot-compiler-dev mailing list