RFR: 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals [v2]

Gui Cao gcao at openjdk.org
Mon Mar 25 01:17:27 UTC 2024


On Wed, 20 Mar 2024 02:47:07 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Gui Cao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into JDK-8328404
>>  - 8328404: RISC-V: Fix potential crash in C2_MacroAssembler::arrays_equals
>
> Looks fine. In fact, array[0] could have an alignement of 32-bit after JDK-8139457 when running with -XX:-UseCompressedClassPointers. In this case, we have base_offset = 20 (bytes). It will also an issue when we add support for lilliput on riscv some day, in which case we will have base_offset = 12 (bytes).

@RealFYang : Thanks for your review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18370#issuecomment-2017041489


More information about the hotspot-compiler-dev mailing list