RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v7]

Galder Zamarreño galder at openjdk.org
Mon Mar 25 09:18:24 UTC 2024


On Thu, 21 Mar 2024 02:39:35 GMT, Dean Long <dlong at openjdk.org> wrote:

> I only wanted the comments around the boilerplate force_reexecute() logic, but if you are happy with my idea to move that logic into LIRGenerator::state_for then the comment could go there. If not, I may look at it in a follow-up RFE, because I would like to get rid of the force_reexecute() hack that I added and see if I can instead tie it to the use of state_before() or ValueStack::StateBefore.

It might be better handled as a follow-up. The reason for the boilerplate code to look the way it does is because the original code didn't set `set_force_reexecute`. So by shaping the code in that way, I was trying to limit the impact of my changes to the specific case of my clone intrinsic, where both state before and force reexecute are set for the new type array and array copy intrinsics.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17667#issuecomment-2017534977


More information about the hotspot-compiler-dev mailing list