RFR: 8324121: SIGFPE in PhaseIdealLoop::extract_long_range_checks [v2]

[Tobias Hartmann]

On Fri, 22 Mar 2024 16:34:48 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> In my opinion ABS() should assert that it has legal input (not MIN_INT) and output (non-negative value) in debug builds.
>
> Thanks for reviewing this.
> We can't get to this code if `stride_con` is `MIN_INT` because some other condition (that doesn't explicitly check that `stride_con` is not `MIN_INT`) causes a bail out from the transformation. I added an explicit bail out in that case in a new commit anyway to make the code more robust.

> In my opinion ABS() should assert that it has legal input (not MIN_INT) and output (non-negative value) in debug builds.

I agree and filed [JDK-8328934](https://bugs.openjdk.org/browse/JDK-8328934) for that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18397#discussion_r1537509551