RFR: 8325252: C2 SuperWord: refactor the packset [v4]

[Emanuel Peter]

On Mon, 25 Mar 2024 10:23:52 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use left/right instead of s1/s2 in some obvious simple places
>
> Nice refactoring. Here are some first comments about the pair set. Will continue later.
> 
> Just a side note: Would it have been possible to split this RFE into a pair set and a pack set refactoring separately without big efforts due to dependencies between them? It might simplify the review.

@chhagedorn I think I have addressed all your remarks.
I agree I could have probably split the `PairSet` and `PackSet` into separate RFE's, that only became apparent once I did the work, and that there is not really any shared code between the two. Though I'm not sure it is worth splitting this up now, after all they are really about the `_packset`.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18276#issuecomment-2017954018