RFR: 8320649: C2: Optimize scoped values [v9]

Emanuel Peter epeter at openjdk.org
Mon Mar 25 13:36:26 UTC 2024


On Mon, 25 Mar 2024 12:49:47 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>>> I see these two extra flag combinations lead to failures:
>>> 
>>> `-XX:+UnlockExperimentalVMOptions -XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0`
>>> 
>>> `-server -Xcomp`
>> 
>> You can try to use `TestFramework::assertDeoptimizedByC2()` which skips the assertion for some unstable setups like having `PerMethodTrapLimit == 0`:
>> https://github.com/openjdk/jdk/blob/700d2b91defd421a2818f53830c24f70d11ba4f6/test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java#L943-L956
>
>> You can try to use `TestFramework::assertDeoptimizedByC2()` which skips the assertion for some unstable setups like having `PerMethodTrapLimit == 0`:
> 
> Thanks for the suggestion! I used it to fix the test.
> @eme64 would you mind re-running tests?

@rwestrel Great, yes just launched it. Feel free to ask in a day or 2 if I don't report back by then!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16966#issuecomment-2018019461


More information about the hotspot-compiler-dev mailing list