RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v4]

[Kangcheng Xu]

On Wed, 20 Mar 2024 12:39:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update the package name for tests
>
> test/hotspot/jtreg/compiler/c2/irTests/TestBoolNodeGvn.java line 58:
> 
>> 56:                 & !(Integer.compareUnsigned((m & x), m) > 0)
>> 57:                 & Integer.compareUnsigned((x & m), m + 1) < 0
>> 58:                 & Integer.compareUnsigned((m & x), m + 1) < 0;
> 
> For easier reading, I would have put the `&` at the end of the line.
> Btw: is this supposed to be a bitwise or a binary and?

Done. I'm intentionally using bitwise `&` here so that the compiler doesn't short-circuits on conditions with `&&`.  We wish to test all for correctness.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18198#discussion_r1537912385