RFR: 8327381 Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value [v7]

Kangcheng Xu kxu at openjdk.org
Tue Mar 26 08:26:46 UTC 2024


> This PR resolves [JDK-8327381](https://bugs.openjdk.org/browse/JDK-8327381)
> 
> Currently the transformations for expressions with patterns `((x & m) u<= m)` or `((m & x) u<= m)` to `true` is in `BoolNode::Ideal` function with a new constant node of value `1` created. However, this is technically a type-improving (reduction in range) transformation that's better suited in `BoolNode::Value` function.
> 
> New unit test `test/hotspot/jtreg/compiler/c2/TestBoolNodeGvn.java` asserting on IR nodes and correctness of this transformation is added and passing.

Kangcheng Xu has updated the pull request incrementally with one additional commit since the last revision:

  apply test only on x64, aarch64 and riscv64

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/18198/files
  - new: https://git.openjdk.org/jdk/pull/18198/files/02c01edf..ae5bed23

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18198&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18198&range=05-06

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/18198.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18198/head:pull/18198

PR: https://git.openjdk.org/jdk/pull/18198


More information about the hotspot-compiler-dev mailing list