RFR: 8328986: Deprecate UseRTM* flags for removal
Vladimir Kozlov
kvn at openjdk.org
Tue Mar 26 18:27:24 UTC 2024
On Tue, 26 Mar 2024 18:23:22 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> src/hotspot/share/runtime/arguments.cpp line 505:
>>
>>> 503: { "RegisterFinalizersAtInit", JDK_Version::jdk(22), JDK_Version::jdk(23), JDK_Version::jdk(24) },
>>> 504: #if defined(X86)
>>> 505: { "UseRTMLocking", JDK_Version::jdk(23), JDK_Version::jdk(24), JDK_Version::jdk(25) },
>>
>> Why do you include experimental options?
>>
>> Only `UseRTMLocking`, `UseRTMDeopt`, and `RTMRetryCount` are product.
>>
>>
>> src/hotspot//cpu/x86/globals_x86.hpp: product(bool, UseRTMLocking, false, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(bool, UseRTMForStackLocks, false, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(bool, UseRTMDeopt, false, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMRetryCount, 5, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMSpinLoopCount, 100, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMAbortThreshold, 1000, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMLockingThreshold, 10000, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMAbortRatio, 50, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(int, RTMTotalCountIncrRate, 64, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(intx, RTMLockingCalculationDelay, 0, EXPERIMENTAL, \
>> src/hotspot//cpu/x86/globals_x86.hpp: product(bool, UseRTMXendForLockBusy, true, EXPERIMENTAL, \
>> src/hotspot//share/opto/c2_globals.hpp: product(bool, PrintPreciseRTMLockingStatistics, false, DIAGNOSTIC, \
>
> I listed all RTM flags to get VM's deprecation message for all of them.
But I missed `PrintPreciseRTMLockingStatistics`. I will added it too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18478#discussion_r1539874399
More information about the hotspot-compiler-dev
mailing list