RFR: 8325252: C2 SuperWord: refactor the packset [v4]

[Emanuel Peter]

On Wed, 27 Mar 2024 09:01:19 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use left/right instead of s1/s2 in some obvious simple places
>
> src/hotspot/share/opto/superword.hpp line 263:
> 
>> 261:   const VLoopBody& _body;
>> 262: 
>> 263:   // The "packset" proper: an array of "packs"
> 
> What do you mean by " The "packset" proper"?

Changed comment to `// Set of all packs:`

> src/hotspot/share/opto/superword.hpp line 488:
> 
>> 486:   bool     do_vector_loop()        { return _do_vector_loop; }
>> 487: 
>> 488:   const PackSet& packset()   const { return _packset; }
> 
> Somehow a strange alignment. You might want to fix that.

Had it aligned with `do_vector_loop`. But it seems unnecessary, changed it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18276#discussion_r1541357933
PR Review Comment: https://git.openjdk.org/jdk/pull/18276#discussion_r1541360704