RFR: 8320649: C2: Optimize scoped values [v9]
Roland Westrelin
roland at openjdk.org
Thu Mar 28 09:21:41 UTC 2024
On Mon, 25 Mar 2024 14:16:20 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>>> > You can try to use `TestFramework::assertDeoptimizedByC2()` which skips the assertion for some unstable setups like having `PerMethodTrapLimit == 0`:
>>>
>>> Thanks for the suggestion! I used it to fix the test. @eme64 would you mind re-running tests?
>>
>> Minor detail: You should use `TestFramework::assertDeoptimizedByC2()` instead of `TestVM::assertDeoptimizedByC2()`. `TestVM` should only be called internally by the framework.
>
>> Minor detail: You should use `TestFramework::assertDeoptimizedByC2()` instead of `TestVM::assertDeoptimizedByC2()`. `TestVM` should only be called internally by the framework.
>
> Thanks for checking the change. I fixed it in the new commit.
> @rwestrel Great, yes just launched it. Feel free to ask in a day or 2 if I don't report back by then!
@eme64 any update on testing?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16966#issuecomment-2024739351
More information about the hotspot-compiler-dev
mailing list