RFR: 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix identical cloning cases used for Loop Unswitching and Split If [v2]

[Christian Hagedorn]

On Wed, 27 Mar 2024 16:13:35 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Change from DFS to 2xBFS
>>  - Review Emanuel first part
>>  - Merge branch 'master' into JDK-8327110
>>  - 8327110: Refactor create_bool_from_template_assertion_predicate() to separate class and fix pure cloning cases used for Loop Unswitching and Split If
>
> test/hotspot/jtreg/compiler/predicates/TestCloningWithManyDiamondsInExpression.java line 28:
> 
>> 26:  * @test
>> 27:  * @bug 8327110
>> 28:  * @requires vm.compiler2.enabled
> 
> Is this required?
> Maybe we can move the ` * @run main compiler.predicates.TestCloningWithManyDiamondsInExpression` run to a new `@test` block that does not have this `@requires`? Then other compilers also get tested.

As discussed offline, I'm planning to do that but the test case would currently fail and is only gonna work once the next PR is in (JDK-8327111). I will update the test with that PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18293#discussion_r1542851376