RFR: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs [v2]

[Roland Westrelin]

On Thu, 28 Mar 2024 11:57:59 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Thanks @rwestrel ! Generally makes sense, I have a few suggestions and questions.

Thanks for reviewing this.

> src/hotspot/share/opto/compile.cpp line 3898:
> 
>> 3896:     // as a precedence edge, so they can't float above the cast in case that cast's narrowed type helped eliminated a
>> 3897:     // range check or a null divisor check.
>> 3898:     assert(cast->in(0) != nullptr, "");
> 
> Suggestion:
> 
>     assert(cast->in(0) != nullptr, "All RangeCheck CastII must have a control dependency");

Done in new commit.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18377#issuecomment-2025282505
PR Review Comment: https://git.openjdk.org/jdk/pull/18377#discussion_r1543052231