RFR: 8329355: Test compiler/c2/irTests/TestIfMinMax.java fails on RISC-V
Fei Yang
fyang at openjdk.org
Sat Mar 30 08:53:42 UTC 2024
Please review this small change fixing an IR matching failure on linux-riscv platform.
JDK-8324655 tries to identify min/max patterns in CMoves and transform them into Min and Max nodes.
But architectures like RISC-V doesn't have support of conditional moves at the ISA level for now.
So we set ConditionalMoveLimit parameter to 0 for this platform and conditionals moves are emulated
with normal compare and branch instructions instead [1]. This is why the IR matching test added by
JDK-8324655 fails on this platform. A simple way to fix this would be skip this test for this case.
[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/riscv.ad#L9775
-------------
Commit messages:
- fix
Changes: https://git.openjdk.org/jdk/pull/18558/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18558&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8329355
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/18558.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18558/head:pull/18558
PR: https://git.openjdk.org/jdk/pull/18558
More information about the hotspot-compiler-dev
mailing list