RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v7]

Steve Dohrmann duke at openjdk.org
Wed May 1 17:46:30 UTC 2024


On Mon, 29 Apr 2024 22:06:11 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix 4 more src_is_gpr = true cases, add asserts to check for UseAPX
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 2632:
> 
>> 2630:     prefix(src, true /* is_map1 */);
>> 2631:     emit_int8((unsigned char)0xAE);
>> 2632:     emit_operand(as_Register(2), src, 0);
> 
> Even when UseAVX > 0, if the src address uses higher bank registers, ldmxcsr/stmxcsr should be encoded using the REX2  i.e. the else path.

Thank you, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1586556997


More information about the hotspot-compiler-dev mailing list