RFR: 8329982: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found

[Tom Rodriguez]

On Wed, 1 May 2024 15:03:08 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR adds the missing nmethod entry barriers to JVMCI hand assembled tests.
> It also closes the escape hatch in jvmciCodeInstaller.cpp that allowed JVMCI code to be installed without nmethod entry barriers.

src/hotspot/share/jvmci/jvmciCodeInstaller.cpp line 777:

> 775:     // configurations which generate assembly without being a full compiler. So for now we enforce
> 776:     // that JIT compiled methods must have an nmethod barrier.
> 777:     bool install_default = JVMCIENV->get_HotSpotNmethod_isDefault(installed_code) != 0;

This line is no longer needed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19035#discussion_r1586558212