RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v8]

[Steve Dohrmann]

On Wed, 1 May 2024 21:04:50 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add egpr support for popcntq(R,A), cvttsd2siq(R,A), popq(R)
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 14001:
> 
>> 13999:   emit_int8((unsigned char)0xF3);
>> 14000:   prefixq(src, dst, true /* is_map1 */);
>> 14001:   emit_int8((unsigned char)0xB8);
> 
> Just a nit, this could be:
> emit_prefix_and_int8(get_prefixq(src, dst, true /* is_map1 */), (unsigned char) 0xB8);

Thanks, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1586933658