RFR: 8329982: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found [v2]

[Dean Long]

On Wed, 1 May 2024 20:57:14 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> This PR adds the missing nmethod entry barriers to JVMCI hand assembled tests.
>> It also closes the escape hatch in jvmciCodeInstaller.cpp that allowed JVMCI code to be installed without nmethod entry barriers.
>
> Doug Simon has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove vestiges of optional JVMCI nmethod support for entry barriers
>  - fixed failing tests and removed tests that install no longer valid code

Wouldn't it be useful for the JVMCI implementation to provide the nmethod entry barrier code?  I could be wrong, but I think all the JIT compiler needs to know is how big it is, so it can reserve the space (NOPs would do), then when the code is installed as an nmethod, memcpy it over (if it's static), or use the MacroAssembler if it's not.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19035#issuecomment-2089363560