RFR: 8331418: ZGC: generalize barrier liveness logic [v2]

Thu May 2 15:28:54 UTC 2024

On Thu, 2 May 2024 13:37:14 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Can we change `_barrier_set_state` (
> 
> https://github.com/openjdk/jdk/blob/a024eed7384828643e302f021a253717f53e3778/src/hotspot/share/opto/compile.hpp#L364
> 
> ) from `void*` to `BarrierSetC2State*` and remove the casts?

Thanks for the suggestion, this would be a nice improvement, however it would be fairly pervasive (I sketched it it in https://github.com/openjdk/jdk/commit/cf5c1587e0ea90a8b3de4c70e0a2bf6ba4158f15), so I think it would be better to apply it as a separate RFE, perhaps after [non-generational ZGC is removed](https://openjdk.org/jeps/474) for simplicity. What do you think?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19026#issuecomment-2090805965