RFR: 8331185: Enable compiler memory limits in debug builds [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri May 3 19:16:54 UTC 2024
On Mon, 29 Apr 2024 18:57:16 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>>> Thank you, @tstuefe, for filing these bugs.
>>>
>>> One additional thing I noticed is that we don't produce compilation replay file (its size is 0) for such failures. Can you look why is that?
>>
>> Yes, its https://bugs.openjdk.org/browse/JDK-8331344 . I'll post a PR shortly.
>>
>> The problem behind this is more generic, namely that producing replay files needs resource area, and it shouldn't. We should not allocate resource area or heap in fatal error handling. But for now, I'll fix this locally by avoiding the recursion.
>
>> > Thank you, @tstuefe, for filing these bugs.
>> > One additional thing I noticed is that we don't produce compilation replay file (its size is 0) for such failures. Can you look why is that?
>>
>> Yes, its https://bugs.openjdk.org/browse/JDK-8331344 . I'll post a PR shortly.
>>
>> The problem behind this is more generic, namely that producing replay files needs resource area, and it shouldn't. We should not allocate resource area or heap in fatal error handling. But for now, I'll fix this locally by avoiding the recursion.
>
> Good. I think we need to push it before this PR.
@vnkozlov SAP did a test series and did not find any issues in their CI
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18969#issuecomment-2093618707
More information about the hotspot-compiler-dev
mailing list