RFR: 8330016: Stress seed should be initialized for runtime stub compilation
Roberto Castañeda Lozano
rcastanedalo at openjdk.org
Mon May 6 09:44:53 UTC 2024
On Mon, 6 May 2024 06:31:47 GMT, Daniel Skantz <duke at openjdk.org> wrote:
> We can initialize the stress seed for runtime stub compilation as we already do for method compilation. This found the bug described in JDK-8329258. It would apply if StressGCM or StressLCM vm flags are set.
>
> Testing: T1-5 default options. T1-5 with -XX:+StressLCM and -XX:+StressGCM. Manually tested that the stress seed is set and printed to compilation log if either stress option is set.
src/hotspot/share/opto/compile.cpp line 5066:
> 5064: // Auxiliary methods to support randomized stressing/fuzzing.
> 5065:
> 5066: void Compile::initialize_stress_seed(DirectiveSet* directive) {
Suggestion:
void Compile::initialize_stress_seed(const DirectiveSet* directive) {
src/hotspot/share/opto/compile.hpp line 1282:
> 1280:
> 1281: // seed random number generation and log the seed for repeatability.
> 1282: void initialize_stress_seed(DirectiveSet* directive);
Suggestion:
void initialize_stress_seed(const DirectiveSet* directive);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19095#discussion_r1590770840
PR Review Comment: https://git.openjdk.org/jdk/pull/19095#discussion_r1590771133
More information about the hotspot-compiler-dev
mailing list