RFR: 8320649: C2: Optimize scoped values [v9]

Roland Westrelin roland at openjdk.org
Mon May 6 12:00:00 UTC 2024


On Mon, 6 May 2024 08:25:10 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> I'm thinking in particular about your most recent changes with:
> 
>     * `class Invariance`
> 
>     * `estimate_if_peeling_possible`
> 
> 
> Don't get me wrong: I like those refactorings, but they should be done separately.

The problem I see is that they have little value unless this patch is integrated as it is. What if another reviewer thinks it's better to keep everything related to loop predication together? There's no need to change the class `Invariance` then.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16966#issuecomment-2095842139


More information about the hotspot-compiler-dev mailing list