Integrated: 8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()

Emanuel Peter epeter at openjdk.org
Tue May 7 07:11:01 UTC 2024


On Mon, 6 May 2024 11:25:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> In the `MergeStore` logic, I check the `adr_type()`. But in some rare cases this can be a `nullptr`, I did not expect that.
> 
> Exampe: during IGVN, the address is dying, with TOP somewhere in the inputs.
> 
>    1 Con === 0 [[ ]] #top
> 1022 AddP === _ 1 1 41 [[ 1019 1021 ]] !orig=539,[572] !jvms: Test::dMeth @ bci:223 (line 35)
> 1019 StoreI === 1128 827 1022 1020 [[ 1075 541 1073 574 ]] @int[int:>=0] (java/lang/Cloneable,java/io/Serializable):exact+any *, idx=6; Memory: @null !orig=574,1068 !jvms: Test::dMeth @ bci:227 (line 35)
> 
> I now check for `nullptr`.

This pull request has now been integrated.

Changeset: df1ff056
Author:    Emanuel Peter <epeter at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/df1ff056f19ce569e05b0b87584e289840fc5d5c
Stats:     64 lines in 2 files changed: 63 ins; 0 del; 1 mod

8331085: Crash in MergePrimitiveArrayStores::is_compatible_store()

Reviewed-by: thartmann, chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/19103


More information about the hotspot-compiler-dev mailing list