RFR: 8325520: Vector loads with offsets incorrectly compiled [v6]

Emanuel Peter epeter at openjdk.org
Tue May 7 12:47:02 UTC 2024


On Tue, 7 May 2024 12:28:32 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Damon Fenacci has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8325520: add store/load masked vector tests
>>  - JDK-8325520: add store/load tests with duplicate offsets
>
> src/hotspot/share/opto/memnode.cpp line 3546:
> 
>> 3544:           const StoreVectorScatterMaskedNode* svgm = mem->as_StoreVectorScatterMasked();
>> 3545:           if (offsets->eqv_uncast(svgm->in(StoreVectorScatterMaskedNode::Offsets)) &&
>> 3546:             mask->eqv_uncast(svgm->in(StoreVectorScatterMaskedNode::Mask))) {
> 
> Suggestion:
> 
>               mask->eqv_uncast(svgm->in(StoreVectorScatterMaskedNode::Mask))) {

Alignment was off

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18347#discussion_r1592399246


More information about the hotspot-compiler-dev mailing list