RFR: 8325438: Add exhaustive tests for Math.round intrinsics [v13]

[Emanuel Peter]

On Tue, 7 May 2024 13:23:48 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix issues; modify vm options to make sure test the expected behaviors.
>
> test/hotspot/jtreg/compiler/floatingpoint/TestRoundFloatAll.java line 31:
> 
>> 29:  * @library /test/lib /
>> 30:  * @modules java.base/jdk.internal.math
>> 31:  * @run main/othervm -XX:-TieredCompilation -XX:CompileThresholdScaling=0.3 -XX:+PrintIdeal -XX:CompileCommand=compileonly,compiler.floatingpoint.TestRoundFloatAll::test* -XX:-UseSuperWord compiler.floatingpoint.TestRoundFloatAll
> 
> please break up the line for easier reading

Why these flags:
`-XX:-TieredCompilation -XX:CompileThresholdScaling=0.3 -XX:+PrintIdeal -XX:-UseSuperWord` ?

I also suggest that you use `-Xbatch`, just to make sure we have compiled all relevant methods after the warmup. If things get too slow, then maybe you want to consider using explicit compile exclusion / forbidding inlining for the `test*` method, rather than the compileonly, which prevents everything else from compiling.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1592498081