RFR: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331 [v2]

[Vladimir Kozlov]

On Tue, 7 May 2024 19:03:28 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Added a strcmp for unsafe_setmemory in process_call_arguments() so the assert would not trigger.
>> 
>> I believe this is the correct fix as I do not think the arguments for setMemory need special handling like arraycopy.
>> 
>> I would like suggestions on how to generate a testcase to catch this type of error in mainline.
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test for setMemory escape

Few comments about test.

test/hotspot/jtreg/compiler/escapeAnalysis/Test8331033.java line 2:

> 1: /*
> 2:  * Copyright (c) 2020, Red Hat, Inc. All rights reserved.

Suggestion:

 * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

test/hotspot/jtreg/compiler/escapeAnalysis/Test8331033.java line 28:

> 26:  * @bug 8331033
> 27:  * @summary EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331
> 28:  *

Suggestion:

 * @requires vm.compMode != "Xint"

test/hotspot/jtreg/compiler/escapeAnalysis/Test8331033.java line 29:

> 27:  * @summary EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331
> 28:  *
> 29:  * @run main/othervm -XX:+PrintEscapeAnalysis -Xbatch -XX:-TieredCompilation  Test8331033

Suggestion:

 * @run main/othervm -Xbatch -XX:-TieredCompilation  Test8331033

test/hotspot/jtreg/compiler/escapeAnalysis/Test8331033.java line 56:

> 54:  * // "Escape Analysis for Java", Proceedings of ACM SIGPLAN
> 55:  * // OOPSLA Conference, November 1, 1999
> 56:  */

No need for this comment. We have it in HotSpot sources, in `opto/escape.hpp`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19032#pullrequestreview-2044189508
PR Review Comment: https://git.openjdk.org/jdk/pull/19032#discussion_r1593090598
PR Review Comment: https://git.openjdk.org/jdk/pull/19032#discussion_r1593092676
PR Review Comment: https://git.openjdk.org/jdk/pull/19032#discussion_r1593093151
PR Review Comment: https://git.openjdk.org/jdk/pull/19032#discussion_r1593094736