RFR: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331 [v3]

Scott Gibbons sgibbons at openjdk.org
Tue May 7 21:17:23 UTC 2024


> Added a strcmp for unsafe_setmemory in process_call_arguments() so the assert would not trigger.
> 
> I believe this is the correct fix as I do not think the arguments for setMemory need special handling like arraycopy.
> 
> I would like suggestions on how to generate a testcase to catch this type of error in mainline.

Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  Review comments - change copyright, add @requires, change @run

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19032/files
  - new: https://git.openjdk.org/jdk/pull/19032/files/e938e57c..6c1bedf1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19032&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19032&range=01-02

  Stats: 12 lines in 1 file changed: 1 ins; 9 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/19032.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19032/head:pull/19032

PR: https://git.openjdk.org/jdk/pull/19032


More information about the hotspot-compiler-dev mailing list