RFR: 8331033: EA fails with "EA unexpected CallLeaf unsafe_setmemory" after JDK-8329331 [v3]

Vladimir Kozlov kvn at openjdk.org
Wed May 8 14:30:54 UTC 2024


On Tue, 7 May 2024 21:17:23 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> Added a strcmp for unsafe_setmemory in process_call_arguments() so the assert would not trigger.
>> 
>> I believe this is the correct fix as I do not think the arguments for setMemory need special handling like arraycopy.
>> 
>> I would like suggestions on how to generate a testcase to catch this type of error in mainline.
>
> Scott Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments - change copyright, add @requires, change @run

My testing passed.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19032#pullrequestreview-2045845632


More information about the hotspot-compiler-dev mailing list