RFR: 8331862: Remove split relocation info implementation [v2]

Dean Long dlong at openjdk.org
Wed May 8 19:14:56 UTC 2024


On Wed, 8 May 2024 16:48:02 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> [Split relocation info](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/code/relocInfo.hpp#L225) was used only for SPARC. Non of current OpenJDK platforms use it.
>> 
>> Tested tier1-3,stress,xcomp.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   clean up comments

src/hotspot/share/code/relocInfo.hpp line 133:

> 131: //   Data:  []       an oop stored in 4 bytes of instruction
> 132: //          [n]      n is the index of an oop in the CodeBlob's oop pool
> 133: //          [Nn]     index may be 32 bits if necessary

Lines 132 and 133 could be combined into something like:

// [[N]n]  index of an oop in the CodeBlob's oop pool

which seems consistent with other descriptions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19126#discussion_r1594515706


More information about the hotspot-compiler-dev mailing list