RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v15]

[Steve Dohrmann]

On Wed, 8 May 2024 09:52:04 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   parameter and local renames, update comment
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 1971:
> 
>> 1969: void Assembler::crc32(Register crc, Register v, int8_t sizeInBytes) {
>> 1970:   assert(VM_Version::supports_sse4_2(), "");
>> 1971:   if (needs_rex2(crc, v)) {
> 
> This being a map2 instruction should check for needs eevex, rex2 nomenclature looks misleading here.

Thanks for the comment.  Although crc32 is the only promoted map2 instruction (currently) implemented in the assembler, additional map2 instructions may be added later.  I added ::needs_eevex and used as you suggest in the crc32 instr.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1594808629