RFR: 8320725: C2: Add "requires_strict_order" flag for floating-point add-reduction [v8]

Emanuel Peter epeter at openjdk.org
Mon May 13 06:01:33 UTC 2024


On Wed, 8 May 2024 20:22:51 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

> I am not sure if I fully understand what's expected in the JTREG tests. Should I be verifying the -XX:+PrintIdeal output to make sure the correct message is being printed for the ReductionV* nodes?

Yes, the IR framework basically does regex matching against the PrintIdeal graph. For example: `counts = {IRNode.STORE_VECTOR, ">0"}` in the `@IR` rule executes the regex for the store vector, and checks if we find more than zero occurances.

Maybe you can just use a regex string directly for your special IR rule. Alternatively, you could have them in the `IRNode` class, but not sure that's worth it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18034#issuecomment-2106712934


More information about the hotspot-compiler-dev mailing list