RFR: 8329273: C2 SuperWord: Some basic MemorySegment IR tests [v2]

[Emanuel Peter]

On Mon, 13 May 2024 06:34:45 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 25 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8329273-memory-segment-ir-tests
>>  - fix tabs
>>  - speed up test
>>  - small cosmetic fix
>>  - make things static
>>  - long loop tests
>>  - handle AlignVector
>>  - int cases
>>  - int-index case
>>  - disable mixed tests
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/aa5b224f...6f760dfd
>
> test/hotspot/jtreg/compiler/loopopts/superword/TestMemorySegment.java line 447:
> 
>> 445:     @IR(counts = {IRNode.LOAD_VECTOR_B, "= 0",
>> 446:                   IRNode.ADD_VB,        "= 0",
>> 447:                   IRNode.STORE_VECTOR,  "= 0"},
> 
> You should use `failOn` instead of `= 0`. Same for other tests.

I honestly prefer "= 0", because it is easier to flip to "> 0", and keeps the same style that way. But I guess that is really a matter of taste.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18535#discussion_r1597982303