RFR: 8329273: C2 SuperWord: Some basic MemorySegment IR tests [v2]

Emanuel Peter epeter at openjdk.org
Mon May 13 07:38:11 UTC 2024


On Mon, 13 May 2024 06:42:42 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 25 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8329273-memory-segment-ir-tests
>>  - fix tabs
>>  - speed up test
>>  - small cosmetic fix
>>  - make things static
>>  - long loop tests
>>  - handle AlignVector
>>  - int cases
>>  - int-index case
>>  - disable mixed tests
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/7eaa6f7c...6f760dfd
>
> test/hotspot/jtreg/compiler/loopopts/superword/TestMemorySegment.java line 199:
> 
>> 197:         tests.put("testMemorySegmentBadExitCheck", () -> {
>> 198:             return testMemorySegmentBadExitCheck(copy(a));
>> 199:         });
> 
> Same as above, you can replace this with an expression lambda:
> Suggestion:
> 
>         tests.put("testIntLoop_longIndex_intInvar_sameAdr_byte", 
>                   () -> testIntLoop_longIndex_intInvar_sameAdr_byte(copy(a), 0));
> 
> Same for others.

Nice idea!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18535#discussion_r1598006814


More information about the hotspot-compiler-dev mailing list