RFR: 8302850: Implement C1 clone intrinsic that reuses arraycopy code for primitive arrays [v15]

Galder Zamarreño galder at openjdk.org
Mon May 13 08:15:14 UTC 2024


On Wed, 8 May 2024 10:04:10 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Galder Zamarreño has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix assert to only have a single !
>
> src/hotspot/share/c1/c1_GraphBuilder.cpp line 2031:
> 
>> 2029:       ciType* type = receiver->exact_type();
>> 2030:       if (type != nullptr && type->is_loaded()) {
>> 2031:         assert(!type->as_instance_klass()->is_interface(), "");
> 
> Suggestion:
> 
>         assert(!type->is_instance_klass() || !type->as_instance_klass()->is_interface(), "");

Thanks @dean-long for the suggested fix. CI looks good now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17667#discussion_r1598054058


More information about the hotspot-compiler-dev mailing list