RFR: 8330584: IGV: XML does not save all node properties [v2]

Tobias Holenstein tholenstein at openjdk.org
Mon May 13 09:18:10 UTC 2024


On Fri, 10 May 2024 09:37:44 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update src/utils/IdealGraphVisualizer/Coordinator/src/main/java/com/sun/hotspot/igv/coordinator/OutlineTopComponent.java
>>   
>>   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> Just a general thought: Should we generally only save in `.igv` format and drop (explicit) saving in XML format or is there any benefit to be able to store in both formats?

thanks for the reviews @chhagedorn and @robcasloz

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19104#issuecomment-2107054910


More information about the hotspot-compiler-dev mailing list