RFR: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension

Fei Yang fyang at openjdk.org
Tue May 14 04:31:01 UTC 2024


On Mon, 13 May 2024 08:14:43 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to reivew this simple patch to remove some wrong instrunctions on riscv?
> These instrunctions are wrong in that e.g. take `vror.vx` as example,
> * by definition of spec, it should be `vror.vx vd, vs2, *rs1*, vm`
> * the implementation here, it is indeed `vror_vx(VectorRegister Vd, VectorRegister Vs2, *VectorRegister* Vs1, VectorMask vm = unmasked)`
> 
> Thanks

I think you mean the `funct3` (`OPIVV` vs `OPIVX`) encoding is wrong?

-------------

PR Review: https://git.openjdk.org/jdk/pull/19211#pullrequestreview-2054252934


More information about the hotspot-compiler-dev mailing list