RFR: 8331934: [s390x] Add support for primitive array C1 clone intrinsic

[Amit Kumar]

On Mon, 13 May 2024 17:08:03 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> Adds JDK-8302850 Port for s390x. 
> 
> Testing: 
> 
> make test TEST="hotspot_compiler" JTREG="JAVA_OPTIONS=-XX:TieredStopAtLevel=1"
> 
> ==============================                                                                                                          
> Test summary                                                                                                                            
> ==============================                                                                                                          
>    TEST                                              TOTAL  PASS  FAIL ERROR                                                            
>    jtreg:test/hotspot/jtreg:hotspot_compiler          1166  1166     0     0                                                            
> ==============================                                                                                                          
> TEST SUCCESS
> 
> * Tier1 Test with Fast debug build. 
> 
> BenchMarking:
> 
> 
> Without Patch: 
> 
> Benchmark                 (size)  Mode  Cnt     Score    Error  Units
> ArrayClone.byteArraycopy       0  avgt   15    10.838 ±  0.461  ns/op
> ArrayClone.byteArraycopy      10  avgt   15    28.919 ±  1.695  ns/op
> ArrayClone.byteArraycopy     100  avgt   15    48.815 ±  0.901  ns/op
> ArrayClone.byteArraycopy    1000  avgt   15   256.357 ±  7.901  ns/op
> ArrayClone.byteClone           0  avgt   15    90.398 ±  3.119  ns/op
> ArrayClone.byteClone          10  avgt   15   103.774 ±  4.468  ns/op
> ArrayClone.byteClone         100  avgt   15   126.628 ±  6.952  ns/op
> ArrayClone.byteClone        1000  avgt   15   326.409 ± 31.635  ns/op
> ArrayClone.intArraycopy        0  avgt   15    10.450 ±  0.509  ns/op
> ArrayClone.intArraycopy       10  avgt   15    36.903 ±  0.753  ns/op
> ArrayClone.intArraycopy      100  avgt   15    85.964 ±  1.806  ns/op
> ArrayClone.intArraycopy     1000  avgt   15   841.512 ± 40.335  ns/op
> ArrayClone.intClone            0  avgt   15    89.332 ±  3.695  ns/op
> ArrayClone.intClone           10  avgt   15   110.639 ±  2.476  ns/op
> ArrayClone.intClone          100  avgt   15   195.781 ±  8.622  ns/op
> ArrayClone.intClone         1000  avgt   15  1058.479 ± 92.468  ns/op
> Finished running test 'micro:java.lang.ArrayClone'
> 
> 
> with patch:
> 
> Benchmark                 (size)  Mode  Cnt    Score    Error  Units
> ArrayClone.byteArraycopy       0  avgt   15   10.526 ±  0.289  ns/op
> ArrayClone.byteArraycopy      10  avgt   15   27.110 ±  0.656  ns/op
> Arra...

@RealLucy @TheRealMDoerr Would you please review this one. :-) 

Testing seems clear on s390x. I have posted Benchmark result as well. 

Please let me know if any further testing is required.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19220#issuecomment-2109594090