RFR: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null() [v2]

[Tobias Hartmann]

On Tue, 14 May 2024 16:28:17 GMT, Roland Westrelin <roland at openjdk.org> wrote:

>> The `If` node that's created by `GraphKit::must_be_not_null()` is not
>> enqueued for igvn when it's created. The test case shows it prevents 2
>> identical tests from commoning when the first igvn executes. This is a
>> minor issue I noticed whule working on something else.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed test @summary

Looks good to me otherwise.

src/hotspot/share/opto/graphKit.cpp line 1471:

> 1469:   IfNode *iff = new IfNode(control(), opaq, PROB_MAX, COUNT_UNKNOWN);
> 1470:   _gvn.set_type(iff, iff->Value(&_gvn));
> 1471:   if (!tst->is_Con())  record_for_igvn(iff);

Suggestion:

  if (!tst->is_Con()) {
    record_for_igvn(iff);
  }

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19233#pullrequestreview-2056364490
PR Review Comment: https://git.openjdk.org/jdk/pull/19233#discussion_r1600599026