RFR: 8324517: C2: crash in compiled code because of dependency on removed range check CastIIs [v2]
Tobias Hartmann
thartmann at openjdk.org
Tue May 14 20:45:05 UTC 2024
On Mon, 6 May 2024 10:50:30 GMT, Roland Westrelin <roland at openjdk.org> wrote:
> What you're saying, I think, is that if we have, say, a CastII that's input to a DivI node, if the input to that cast is non zero, then we don't need to add the CastII control as dependency to the DivI
Yes, that was my point.
> That doesn't seem straightforward because this is done once we have no igvn instance to propagate types anymore. So, while I agree this is conservative, it still seems like the most reasonable fix.
Right, we can still go down that path if it ever becomes necessary.
> That seems like a different problem that out of the scope of this particular issue.
Could you please file a follow-up bug for that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18377#discussion_r1600617086
More information about the hotspot-compiler-dev
mailing list