RFR: JDK-8330565 : C2: Multiple crashes with CTW after JDK-8316991 [v2]

[Cesar Soares Lucas]

On Thu, 9 May 2024 01:26:00 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Cesar Soares Lucas has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refactor split_castpp_load_through_phi
>
> src/hotspot/share/opto/escape.cpp line 779:
> 
>> 777:     _igvn->set_type(data_phi,  new_t);
>> 778:     data_phi->raise_bottom_type(new_t);
>> 779:   }
> 
> Do you intentionally execute `_igvn->transform(` for `data_phi` before you set inputs and now type?
> Usually we do transform after we fully construct node.

I used to call `transform` right after the nodes were created. Thanks for clarifying on the right way to use it. I refactored this method to call `transform` only after the nodes have all inputs set - doing that alone doesn't fix the problem, though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19147#discussion_r1600914310