RFR: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null() [v2]
Christian Hagedorn
chagedorn at openjdk.org
Wed May 15 06:27:01 UTC 2024
On Tue, 14 May 2024 16:28:17 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> The `If` node that's created by `GraphKit::must_be_not_null()` is not
>> enqueued for igvn when it's created. The test case shows it prevents 2
>> identical tests from commoning when the first igvn executes. This is a
>> minor issue I noticed whule working on something else.
>
> Roland Westrelin has updated the pull request incrementally with one additional commit since the last revision:
>
> fixed test @summary
Looks good to me, too.
-------------
Marked as reviewed by chagedorn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19233#pullrequestreview-2056992695
More information about the hotspot-compiler-dev
mailing list