RFR: 8332394: Add friendly output when @IR rule missing value [v2]

Hamlin Li mli at openjdk.org
Thu May 16 16:09:28 UTC 2024


> Hi,
> Can you help to review this simple patch?
> Currently, when a @IR rule like "applyIfPlatform" or "applyIfCPUFeature" miss a value, it will just throw ArrayIndexOutOfBoundsException, with no other information. This is confusing unless you dig into the test frame code.
> It's helpful to output more meaningful information.
> Thanks

Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:

  add more information in output

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19270/files
  - new: https://git.openjdk.org/jdk/pull/19270/files/529257fd..7945f8fb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19270&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19270&range=00-01

  Stats: 14 lines in 1 file changed: 0 ins; 0 del; 14 mod
  Patch: https://git.openjdk.org/jdk/pull/19270.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19270/head:pull/19270

PR: https://git.openjdk.org/jdk/pull/19270


More information about the hotspot-compiler-dev mailing list