RFR: 8317720: RISC-V: Implement Adler32 intrinsic [v7]

[Vladimir Kempik]

On Thu, 16 May 2024 13:03:24 GMT, ArsenyBochkarev <duke at openjdk.org> wrote:

>> Hello everyone! Please review this ~non-vectorized~ implementation of `_updateBytesAdler32` intrinsic. Reference implementation for AArch64 can be found [here](https://github.com/openjdk/jdk9/blob/master/hotspot/src/cpu/aarch64/vm/stubGenerator_aarch64.cpp#L3281).
>> 
>> ### Correctness checks
>> 
>> Test `test/hotspot/jtreg/compiler/intrinsics/zip/TestAdler32.java` is ok. All tier1 also passed.
>> 
>> ### Performance results on T-Head board
>> 
>> Enabled intrinsic:
>> 
>> | Benchmark                          |    (count) |  Mode |  Cnt  |   Score  |  Error |  Units |
>> | ------------------------------------- | ----------- | ------ | --------- | ------ | --------- | ---------- |
>> | Adler32.TestAdler32.testAdler32Update |      64 | thrpt  | 25 | 5522.693 | 23.387 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     128 | thrpt |  25 | 3430.761 |  9.210 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     256 | thrpt |  25 | 1962.888 |  5.323 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |     512 | thrpt  | 25 | 1050.938 |  0.144 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    1024 | thrpt  | 25 |  549.227 |  0.375 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    2048 | thrpt  | 25 |  280.829 |  0.170 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    5012 | thrpt  | 25 |  116.333 |  0.057 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |    8192 | thrpt  | 25  |  71.392 |  0.060 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |   16384 | thrpt |  25  |  35.784 |  0.019 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update |   32768 | thrpt |  25  |  17.924 |  0.010 | ops/ms |
>> | Adler32.TestAdler32.testAdler32Update  |  65536 | thrpt |  25  |   8.940 |  0.003 | ops/ms |
>> 
>> Disabled intrinsic:
>> 
>> | Benchmark                          |    (count) |  Mode |  Cnt  |   Score  |  Error |  Units |
>> | ------------------------------------- | ----------- | ------ | --------- | ------ | --------- | ---------- |
>> |Adler32.TestAdler32.testAdler32Update|64|thrpt|25|655.633|5.845|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|128|thrpt|25|587.418|10.062|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|256|thrpt|25|546.675|11.598|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|512|thrpt|25|432.328|11.517|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|1024|thrpt|25|311.771|4.238|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|2048|thrpt|25|202.648|2.486|ops/ms|
>> |Adler32.TestAdler32.testAdler32Update|5012|thrpt|...
>
> ArsenyBochkarev has updated the pull request incrementally with eight additional commits since the last revision:
> 
>  - Prettify L_nmax loop
>  - Add comments in functions
>  - Add explanation comment for L_nmax_loop
>  - Fix L_nmax_loop for big lengths
>  - Fix L_by16 loop step
>  - Prettify intrinsic
>  - Use LMUL=4 for most of the calculations
>  - Use LMUL to load multiple data in one step

Let me please repost the table in a more eye-friendly way


Benchmark | (count) | Mode | Cnt | Score Enabled | Score Disabled | Units
-- | -- | -- | -- | -- | -- | --
Adler32.TestAdler32.testAdler32Update | 64 | thrpt | 25 | 7244.611 | 1319.132 | ops/ms
Adler32.TestAdler32.testAdler32Update | 128 | thrpt | 25 | 4679.629 | 1240.402 | ops/ms
Adler32.TestAdler32.testAdler32Update | 256 | thrpt | 25 | 2740.242 | 1106.121 | ops/ms
Adler32.TestAdler32.testAdler32Update | 512 | thrpt | 25 | 1509.818 | 905.468 | ops/ms
Adler32.TestAdler32.testAdler32Update | 1024 | thrpt | 25 | 791.004 | 684.968 | ops/ms
Adler32.TestAdler32.testAdler32Update | 2048 | thrpt | 25 | 406.103 | 451.938 | ops/ms
Adler32.TestAdler32.testAdler32Update | 5012 | thrpt | 25 | 167.894 | 228.727 | ops/ms
Adler32.TestAdler32.testAdler32Update | 8192 | thrpt | 25 | 171.731 | 150.421 | ops/ms
Adler32.TestAdler32.testAdler32Update | 16384 | thrpt | 25 | 86.127 | 79.323 | ops/ms
Adler32.TestAdler32.testAdler32Update | 32768 | thrpt | 25 | 48.468 | 40.986 | ops/ms
Adler32.TestAdler32.testAdler32Update | 65536 | thrpt | 25 | 23.818 | 19.969 | ops/ms

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18382#issuecomment-2116065601