RFR: 8332394: Add friendly output when @IR rule missing value [v2]
Hamlin Li
mli at openjdk.org
Fri May 17 06:37:06 UTC 2024
On Thu, 16 May 2024 14:36:49 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>>
>> add more information in output
>
> Good catch! Only a small improvement suggestion, otherwise, looks good.
>
> Just noticed that we are actually missing tests that trigger a format violation in `TestBadFormat` for `applyIfCPUFeature*` and `applyIfPlatform*`. We should probably add some at some point, analogously to the ones already there for `applyIf*` for flags. But that could be done separately.
Thanks @chhagedorn for your reviewing!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19270#issuecomment-2116849535
More information about the hotspot-compiler-dev
mailing list