RFR: 8328998: Encoding support for Intel APX extended general-purpose registers [v22]

[Steve Dohrmann]

On Fri, 17 May 2024 09:47:22 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Steve Dohrmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   simplify test in new asserts to just assert UseAPX
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 1005:
> 
>> 1003:   }
>> 1004: 
>> 1005:   if (UseAPX && (UseAVX < 3)) {
> 
> A comment here will be helpful stating the need to disable APX functionality for non AVX512 targets, please note UseAVX is set to level 3 based on existence of CPUID (EAX=07, EBX[16] = AVX512F) bit, and future AVX10 targets may support APX.

Thanks.  I added a comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18476#discussion_r1605370071