RFR: 8320448: Accelerate IndexOf using AVX2 [v19]

[Sandhya Viswanathan]

On Thu, 16 May 2024 17:08:21 GMT, Scott Gibbons <sgibbons at openjdk.org> wrote:

>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 238:
>> 
>>> 236:     const Register needle       = rdx;
>>> 237:     const Register needle_len   = rcx;
>>> 238: 
>> 
>> This is the calling convention on Linux. How is windows platform handled?
>
> The entry code switches Windows calling convention into Linux calling convention by moving/saving registers, which are properly restored on function exit.  This makes register tracking easier.

I don't see the place where the switch is happening before this initial piece of code.  You also have windows tests failing in the GHA. Could you please double check?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16753#discussion_r1605596148