RFR: 8332153: RISC-V: enable tests and add comment for vector shift instruct (shared by vectorization and Vector API) [v2]

[Hamlin Li]

On Mon, 20 May 2024 06:28:18 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix words
>
> src/hotspot/cpu/riscv/riscv_v.ad line 1796:
> 
>> 1794: // check https://docs.oracle.com/javase/specs/jls/se21/html/jls-15.html#jls-15.19 for details.
>> 1795: //
>> 1796: // Shift behaviour in Vector APi is defined as:
> 
> Nit: s/APi/API/

fixed.

> test/hotspot/jtreg/compiler/c2/aarch64/TestVectorShiftShorts.java line 31:
> 
>> 29:  *
>> 30:  * @requires vm.compiler2.enabled
>> 31:  * @requires os.arch == "aarch64" | os.arch == "riscv64"
> 
> Seems a bit weird to enable tests under `test/hotspot/jtreg/compiler/c2/aarch64/` for other cpus?

Yeh, it's bit, removed ` | os.arch == "riscv64"`.

I can also modify the summary and enable the test for riscv if needed.

> test/hotspot/jtreg/compiler/vectorization/runner/ArrayShiftOpTest.java line 103:
> 
>> 101:         counts = {IRNode.RSHIFT_VI, ">0"})
>> 102:     @IR(applyIfPlatform = {"riscv64", "true"},
>> 103:         applyIfCPUFeature = {" v ", "true"},
> 
> Is the spaces around `v` necessary?

Thanks for catching, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19265#discussion_r1606558591
PR Review Comment: https://git.openjdk.org/jdk/pull/19265#discussion_r1606560390
PR Review Comment: https://git.openjdk.org/jdk/pull/19265#discussion_r1606558286